Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location for multivalue rules with generated bodies #7129

Merged

Conversation

anderseknert
Copy link
Member

@anderseknert anderseknert commented Oct 21, 2024

Since there is no body, the location of the head is a better option than simply using the fist scanned token for location.

Fixes #7128

Since there is no body, the location of the head is a better option
than simply using the fist scanned token for location.

Fixes open-policy-agent#7128

Signed-off-by: Anders Eknert <anders@styra.com>
Copy link
Contributor

@charlieegan3 charlieegan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@anderseknert anderseknert merged commit 58ec50b into open-policy-agent:main Oct 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ast: Location Text attribute wrong for multivalue rules with generated body
2 participants