Use new value cache for json.match_schema
#7081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
previously approved these changes
Oct 1, 2024
topdown/jsonschema_test.go
Outdated
| }, | ||
| ) | ||
| if err != nil { | ||
| t.Fatalf("Unexpected schema validation errorerror: %s", err) |
There was a problem hiding this comment.
Suggested change
| t.Fatalf("Unexpected schema validation errorerror: %s", err) | |
| t.Fatalf("Unexpected schema validation error: %s", err) |
srenatus
previously approved these changes
Oct 1, 2024
topdown/jsonschema_test.go
Outdated
| @@ -5,6 +5,8 @@ | |||
| package topdown | |||
|
|
|||
| import ( | |||
| "context" | |||
| "github.com/open-policy-agent/opa/topdown/cache" | |||
There was a problem hiding this comment.
[nit] import ordering seems off here
anderseknert
dismissed stale reviews from srenatus and charlieegan3
via
7bf54ba
anderseknert
force-pushed
the
jsonschema-match-cache
branch
from
f0f9611 to
7bf54ba
Compare
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Added docs @srenatus 👍 |
I figured I'd test this out anyway, and this seemed like a good case given that there was an actual issue on this. Testing response times with OPA running as a server, and the first request is ~800 ms while the following ones are ~10 ms. Fixes open-policy-agent#7011 Signed-off-by: Anders Eknert <anders@styra.com>
anderseknert
force-pushed
the
jsonschema-match-cache
branch
from
7bf54ba to
291a3c2
Compare
charlieegan3
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured I'd test this out anyway, and this seemed like a good case given that there was an actual issue on this.
Testing response times with OPA running as a server, and the first request is ~800 ms while the following ones are ~10 ms.
Fixes #7011
Why the changes in this PR are needed?
What are the changes in this PR?
Notes to assist PR review:
Further comments: