Prepare v0.30.0 release - #3598
Conversation
bbb6060 to
2355493
Compare
tsandall
left a comment
tsandall
left a comment
There was a problem hiding this comment.
LGTM. A few aesthetic comments but nothing major.
There was a problem hiding this comment.
Nit: I usually remove the go package prefix from the changelog lines and try to write something that's a bit more human readable... most users are not familiar w/ the implementation details of OPA so I've found upleveling the changelog notes to be user/deployment centric is good.
There was a problem hiding this comment.
This was a check in the API right? Technically this is backwards compatible so we might want to make this note a bit more understandable for users (right now it's not obvious that your PUT v1/data requests could start failing...)
There was a problem hiding this comment.
Nit: I'd add something like "In case of bundle download or activation errors, reset the cached etag to the last successful activation. Previously OPA would reset the cached etag entirely (which could trigger unnecessary bundle downloads in edge-case scenarios.)"
There was a problem hiding this comment.
Nit: These refer to changes in the opa-envoy-plugin and contrib repos..correct ? Have we includes changes outside of OPA proper in the OPA release notes before ?
There was a problem hiding this comment.
These are docs references to those repos. I don't suppose it's too important to mention them here, let's drop them.
e2c1165 to
39a9294
Compare
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
39a9294 to
c070208
Compare
Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
4 participants
I think the oldest issue resolved in this release is #1954 -- Dec 2019. 👏