-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: vap error logging for rego only templates #3520
fix: vap error logging for rego only templates #3520
Conversation
Signed-off-by: martijnvdp <m.vanderploeg@nl.ccv.eu>
1f8840c
to
3ff7238
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3520 +/- ##
==========================================
- Coverage 54.49% 47.97% -6.53%
==========================================
Files 134 219 +85
Lines 12329 15169 +2840
==========================================
+ Hits 6719 7277 +558
- Misses 5116 7074 +1958
- Partials 494 818 +324
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the PR @martijnvdp!
@JaydipGabani please cherrypick this to 3.17 and cut a release for v3.17.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: martijnvdp <m.vanderploeg@nl.ccv.eu> Co-authored-by: Jaydipkumar Arvindbhai Gabani <gabanijaydip@gmail.com> (cherry picked from commit 7429d70)
Signed-off-by: martijnvdp <m.vanderploeg@nl.ccv.eu> Co-authored-by: Jaydipkumar Arvindbhai Gabani <gabanijaydip@gmail.com> (cherry picked from commit 7429d70) Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
What this PR does / why we need it:
currently logging vap generation errors on rego only templates, this pr changes the
or
operator toand
to exclude the ErrCodeNotDefined errorWhich issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #3516
Special notes for your reviewer: