Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Prepare v3.15.0-beta.0 release #3142

Merged
merged 2 commits into from
Nov 16, 2023
Merged

chore: Prepare v3.15.0-beta.0 release #3142

merged 2 commits into from
Nov 16, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 1, 2023

Automated changes by create-pull-request GitHub action

@github-actions github-actions bot requested a review from a team as a code owner November 1, 2023 23:22
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan
Copy link
Member

sozercan commented Nov 2, 2023

@JaydipGabani do you know why this PR didn't get signed off?

@JaydipGabani
Copy link
Contributor

@sozercan the workflow that ran to raise this PR didn't have signoff change in it. This workflow is missing the change. I am not sure how do we cherry-pick changes to a tag. This is the workflow file I can see in the action that ran, which is the same and missing the signoff change. So this command didn't include --signoff at the end.

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit 51216ee into master Nov 16, 2023
30 of 31 checks passed
@ritazh ritazh deleted the release-v3.15.0-beta.0 branch November 16, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants