Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: statically link gator binary #2840

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

acpana
Copy link
Contributor

@acpana acpana commented Jun 20, 2023

fixes #2825

After changes:

$ make gator && file ./bin/gator
./bin/gator: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=RCa34m4KxNkndGrvlkby/dC7Eydt9Mi5d0rOW8JKV/kC4hP7hRpgDaw8-aOUy2/J8nfYbCPMRkaGM8wTFgV, with debug_info, not stripped

Notice statically linked. Before changes:

$ make gator && file ./bin/gator
./bin/gator: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, Go BuildID=6O50_OD8mTvb3GOw2xK7/YBG9hxjCyAmV2a510vXp/M1QQS4iPBdcfFKct_6Ff/v7D7mRXcr-XX9wI2Ei72, with debug_info, not stripped

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
@acpana acpana requested a review from maxsmythe June 20, 2023 17:27
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the fix!

@acpana acpana merged commit 6aad7b6 into open-policy-agent:master Jun 21, 2023
@ritazh ritazh added this to the v3.13.0 milestone Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gator cli released binary not statically compiled
3 participants