-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: expansion docs rewrite #2707
Conversation
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Co-authored-by: Steven E. Harris <seh@panix.com> Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
Co-authored-by: Steven E. Harris <seh@panix.com> Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
@seh thanks for the suggestions 💯 I'm curious if you are using the We want to make sure this is as easy to use and clear to understand for folks as possible |
I confess that I hadn't even heard of this feature until I was trying to updated my generated CUE definitions for the Mutations API, per cue-lang/cue#2046 (comment). I then started reading the pending and recent Gatekeeper commits, and found this proposal. It took me a few passes over the documentation to realize that this is similar to Kyverno's "auto-gen rules." I have experience fighting against those rules, but I haven't tried Gatekeeper's feature to see how it compares. |
couple comments, but overall looks greatly improved! thanks for looking at this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
website/docs/expansion.md
Outdated
see the [Match Source](#match-source) section below, or to see a working example, | ||
see the [Example](#example) section. | ||
|
||
#### Enforcement Points |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title doesn't match the content.
"Unknown Data"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the title
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
thanks for your feedback before folks 💯 @davis-haba @maxsmythe PTAL 🥇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks!
LGTM! Sorry, I thought I commented last week but apparently not 🤷 |
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com> Signed-off-by: alex <8968914+acpana@users.noreply.github.com> Co-authored-by: Steven E. Harris <seh@panix.com> Signed-off-by: Anlan Du <adu47249@gmail.com>
Been brainstorming how to rewrite some of the expansion docs. Here's a small stab at it. I encourage y'all to use the
suggestion
feature here.