-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update docs #2526
Merged
Merged
chore: update docs #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sozercan
reviewed
Jan 19, 2023
swarren83
force-pushed
the
patch-1
branch
2 times, most recently
from
January 19, 2023 19:11
d504f36
to
12ca6de
Compare
Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com>
Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com>
Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com>
Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com>
Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com>
@sozercan I resolved your comments, please have a look when you have a chance. |
sozercan
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
ritazh
approved these changes
Jan 21, 2023
maxsmythe
approved these changes
Jan 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 7, 2023
* Add note about adding label to ns Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com> * chore: update website docs Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com> * chore: add exempt label note Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com> * fix: add params link Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com> * fix: remove empty line Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com> Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shawn Warren shawn.w.warren@gmail.com
What this PR does / why we need it: Updates documentation to call out the requirement of including a namespace in the controllerManager.exemptNamespaces list in order to add the ignore label.