Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update docs #2526

Merged
merged 7 commits into from
Jan 21, 2023
Merged

chore: update docs #2526

merged 7 commits into from
Jan 21, 2023

Conversation

swarren83
Copy link
Contributor

Signed-off-by: Shawn Warren shawn.w.warren@gmail.com

What this PR does / why we need it: Updates documentation to call out the requirement of including a namespace in the controllerManager.exemptNamespaces list in order to add the ignore label.

website/docs/exempt-namespaces.md Outdated Show resolved Hide resolved
website/docs/exempt-namespaces.md Outdated Show resolved Hide resolved
@swarren83 swarren83 force-pushed the patch-1 branch 2 times, most recently from d504f36 to 12ca6de Compare January 19, 2023 19:11
Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com>
Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com>
Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com>
Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com>
Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com>
@swarren83
Copy link
Contributor Author

@sozercan I resolved your comments, please have a look when you have a chance.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@sozercan sozercan requested a review from a team January 20, 2023 18:58
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit 3c0d690 into open-policy-agent:master Jan 21, 2023
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 7, 2023
* Add note about adding label to ns

Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com>

* chore: update website docs

Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com>

* chore: add exempt label note

Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com>

* fix: add params link

Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com>

* fix: remove empty line

Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com>

Signed-off-by: Shawn Warren <shawn.w.warren@gmail.com>
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants