Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some ready tracker refactor #3146

Closed
acpana opened this issue Nov 2, 2023 · 6 comments · Fixed by #3308
Closed

some ready tracker refactor #3146

acpana opened this issue Nov 2, 2023 · 6 comments · Fixed by #3308

Comments

@acpana
Copy link
Contributor

acpana commented Nov 2, 2023

refactor: replace v1beta references for constraint templates in ReadyTracker

reconsider error management in the ready tracker
@acpana acpana mentioned this issue Nov 2, 2023
Merged
@stale Stale
Copy link

stale bot commented Jan 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 1, 2024
@maxsmythe maxsmythe removed the stale label Jan 3, 2024
@maxsmythe
Copy link
Contributor

removing "stale" b/c of error handling

@stale Stale
Copy link

stale bot commented Mar 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 3, 2024
@maxsmythe
Copy link
Contributor

error handling still needed

@stale stale bot removed the stale label Mar 5, 2024
@David-Jaeyoon-Lee David-Jaeyoon-Lee mentioned this issue Mar 14, 2024
Merged
@stale Stale
Copy link

stale bot commented May 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 4, 2024
@ritazh ritazh removed the stale label May 5, 2024
@stale Stale
Copy link

stale bot commented Jul 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 5, 2024
@ritazh ritazh removed the stale label Jul 5, 2024
@ritazh ritazh closed this as completed in 2244cee Jul 19, 2024
Ankurk99 pushed a commit to Ankurk99/gatekeeper that referenced this issue Aug 1, 2024
@David-Jaeyoon-Lee @sozercan
@JaydipGabani @Ankurk99
fix: open-policy-agent#3146 Support close open/fail for Ready Tracker…
6071a60 
… & surface errors swallowed by grp.Wait() (open-policy-agent#3308)

Signed-off-by: David-Jaeyoon-Lee <davjlee@google.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Co-authored-by: Jaydipkumar Arvindbhai Gabani <gabanijaydip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ritazh @maxsmythe @acpana