Bugfix: quantity calculation for instructions containing strength values #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample error instruction: '1000 mg po tid x 7 days' --> qty is calculated as 21000 instead of 21 - Added logic to adjust `takeMin` and `takeMax` based on strength checks. - Ensured accurate interpretation of frequency and duration for dosage calculations. - Introduced `checkIfStrengthVal` method to validate strength units within instructions.
chitrankd
changed the title
- Added random example generation for instructions input to improve usability. - Added `startShowingSampleInstructions` and `stopShowingSampleInstructions` for placeholder management on focus/blur events. - Updated `prescribe.jsp` to invoke these functions.
- Updated `startShowingSampleInstructions` and `stopShowingSampleInstructions` to manage ripple animations on focus/blur events. - Adjusted `prescribe.jsp` to pass `randId` parameter for unique placeholders. - Added new CSS animations for enhanced visual attention to encourage user to open the modal.
Eliminated 'ripple-wrap', 'ripple-icon', and 'pulse-icon' classes from the instructions help link and image in prescribe.jsp to avoid animation until manually focused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved the issue where medication quantity was incorrectly calculated when strength values (e.g., "1000 mg" or "5g") were misinterpreted as dosage amounts.
Example:
Input instruction:
"1000 mg po tid x 7 days"Expected quantity:
21Previously calculated:
21000Root Cause:
takeMin and takeMax were incorrectly derived from strength values in the instruction, causing incorrect quantity calculations.
Fix Summary:
Added validation for any takeMin or takeMax values greater than 10:
Introduced fallback logic:
Ensured symmetry between takeMin and takeMax when applicable.