Fix email tool crash due to missing _hrm permission in non-Ontario regions #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The email tool was crashing in non-Ontario regions (e.g., British Columbia) when users attempted to compose emails with attachments. This was caused by the system attempting to check for HRM (Hospital Report Manager) attachments, but non-Ontario regions don't have the
_hrmsecurity permission configured since HRM is Ontario-specific.Solution
Added defensive checks:
EmailComposeAction.java: Only prepare HRM attachments for Ontario regionsEmailComposeManager.prepareHRMAttachments(): Return empty list instead of throwing exception- Check if Ontario region → if not, return empty list
- Check if user has
_hrmpermission → if not, return empty list with warning log- Changed from throwing RuntimeException to graceful degradation
HRMUtil.listHRMDocuments(): Added region and permission guards- Return empty list for non-Ontario regions
- Return empty list when
_hrmpermission is missing (with warning log)