Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jaeger Exporter service name mapping in Go #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

IrisTuntun
Copy link

Changes

Update Jaeger Exporter service name mapping in spec-compliance-matrix.md to be supported in Go.

Related issue (open-telemetry/opentelemetry-go#1762)
Fixed by PR (open-telemetry/opentelemetry-go#1776)

CHANGELOG.md Outdated
@@ -40,6 +40,10 @@ release.
- Add initial OpenTracing compatibility section.
([#1101](https://github.com/open-telemetry/opentelemetry-specification/pull/1101))

### Compliance

- Update Jaeger Exporter service name mapping to be supported in Go. ([#TBD])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe we've added CHANGELOG entries for spec compliance matrix updates. This probably isn't needed.

Copy link

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the placeholder for in the changelog?

@IrisTuntun
Copy link
Author

Whats the placeholder for in the changelog?

The placeholder was for the PR number once I created the PR. Now I'm going to revert the CHANGELOG as Anthony suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants