Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert invalid inputs (None and empty string) to empty string for tracer name #17

Closed
wants to merge 8 commits into from

Conversation

eddyleelin
Copy link

@eddyleelin eddyleelin commented May 13, 2021

Description

Specification change #1654 requires invalid names to be converted to an empty string, as described in the tracer specification below. Passing None or the empty string "" as the name parameter to trace.get_tracer(name, version) will now return a tracer with an empty string for tracer.instrumentation_info.name. Full details available in the Trace API specifications.

Fixes #1849

How Has This Been Tested?

  • The test_invalid_instrumentation_info unit test has been updated to expect an empty string for the given invalid inputs, and the tox -e test-core-sdk tests passed.

Does This PR Require a Contrib Repo Change?

Not that I believe, but I may be wrong.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been updated
  • Changelogs have been updated
  • Changes in public API reviewed

Hooray for my first PR!

@eddyleelin eddyleelin changed the title [WIP] Convert invalid inputs (None and empty string) to empty string for tracer name Convert invalid inputs (None and empty string) to empty string for tracer name May 13, 2021
@eddyleelin eddyleelin requested a review from alolita May 13, 2021 21:16
@eddyleelin eddyleelin closed this May 21, 2021
@eddyleelin eddyleelin deleted the update-gettracer branch May 21, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Tracer operation should use an empty string if the specified name is null
4 participants