Convert invalid inputs (None and empty string) to empty string for tracer name #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specification change #1654 requires invalid names to be converted to an empty string, as described in the tracer specification below. Passing
None
or the empty string""
as thename
parameter totrace.get_tracer(name, version)
will now return a tracer with an empty string fortracer.instrumentation_info.name
. Full details available in the Trace API specifications.Fixes #1849
How Has This Been Tested?
tox -e test-core-sdk
tests passed.Does This PR Require a Contrib Repo Change?
Not that I believe, but I may be wrong.
Checklist:
Hooray for my first PR!