UofL prs and some fixes #53
Conversation
Signed-off-by: Jeff Squyres <jeff@squyres.com> (cherry picked from commit 1d867e8)
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 0dcab03: Add prefixing capability to prrte library and bina...
95208cd: prted: support --with-prte-binary-prefix
10f37e9: prte_configure_options.m4: Add --with-prte-binary-...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
hppritcha
force-pushed
the
uofl_prs_and_some_fixes
branch
from
f89ea92 to
b3bdbb2
Compare
|
@hppritcha Given that we're likely to either try to get these commits upstream (in some form -- probably not exactly as they are now, but as some kind of optional functionality), should we squash these down a little? I don't mean squash everything into a single commit -- but there are some Makefile changes and then fixups to thoseMakefile changes, etc. Specifically: I don't think it's necessary to 100% honor the cherry-pick of the original commits. I think we want to honor the original authorship and give credit to the original commit authors, but we can do that through Signed-off-by and/or Co-authored-by types of attributions in the commit messages. What do you think? |
|
that sounds good to me. Also, I'll repoint the PR to an ompi_main branch to be generated shortly. |
|
@jsquyres could you delete the |
Done |
Add configure CLI option to allow optionally prefixing PRTE binary and library filenames. prted: support --with-prte-binary-prefix Add the prefix to the prted binary name that was passed in via --with-prte-binary-prefix. Add prefixing capability to prrte library and binaries Updated Makefile.am files to include @PRTE_BINARY_PREFIX@ in library and binary names where appropriate. Verified successful build and functionality of prefixed binaries This commit ensures compatiblity with prefixed binary naming while maintaining the integrity of the build system and runtime. Added and finalized ompi- prefix updates for PRRTE manpages. Added ompi- prefix for all instances of prte commands within both the man/man1 and man/man5 directories, and also renamed necessary files to accommodate changes. Updated and corrected ompi- prefix for prrte manpages Finalized changes to prrte manpages with -ompi prefix Changed configuration.rst file to fix warning that is being treated as an error Also fixed docs/Makefile.am for appropriate file renames Turned main function in prte.c into library function provided in libprrte.so manual addition of much of the content of UofL work in uofl-capstone-open-mpi#6 avoid defining PRTE_BINARY_PREFIX twice makefile fixes for prrte binary prefixing There were changes to PRRTE after UofL merged uofl-capstone-open-mpi#9 into their fork of prrte. These changes get it working again. modify some makefiles that UofL somehow missed Signed-off-by: Howard Pritchard <howardp@lanl.gov>
hppritcha
force-pushed
the
uofl_prs_and_some_fixes
branch
from
4ca2e9c to
1e939fe
Compare
No description provided.