hwloc: enable --enable-plugins when appropriate #9921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running configure on the internal hwloc, enable plugins via the --enable-plugins option when 1) --disable-dlopen was not specified and 2) the user didn't add some variant of --enable-plugins on the configure line already. The motivation for this change is to not pull in hwloc dependencies like libcuda in the general case. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Member
Author
|
This is in reference to the problem highlighted in #9907. |
This was referenced Jan 25, 2022
jsquyres
approved these changes
Jan 25, 2022
Member
Author
|
For posterity sake, a quick note about plugins from hwloc. In times past, that would cause some dependency problems, because hwloc was dlopened into the MPI executable by libopen-pal.so. With Open MPI 5.0 and master, hwloc is just a normal library that libopen-pal.so depends on, so there's no chained loading problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running configure on the internal hwloc, enable plugins via
the --enable-plugins option when 1) --disable-dlopen was not
specified and 2) the user didn't add some variant of
--enable-plugins on the configure line already. The motivation
for this change is to not pull in hwloc dependencies like libcuda
in the general case.
Signed-off-by: Brian Barrett bbarrett@amazon.com