v5.0.x: compiler warning fixes #9830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that free(NULL) is legal in C99, so remove the "__opal_attribute_nonnull__(1)" attribute from the buffer param to opal_free() debug wrapper. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 3037dfd)
Also, remove a superflous (uintptr_t) cast, and add an obvious "else" to make the code a little more readable. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit a24846e)
bosilca
approved these changes
Jan 4, 2022
bwbarrett
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the v5.0.x version of the master PR #9814.
See individual commit messages for details.