Skip to content

MPI4:implement MPI_Comm_idup_with_info #9707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 24, 2022
Merged

MPI4:implement MPI_Comm_idup_with_info #9707

merged 3 commits into from
Jan 24, 2022

Conversation

hppritcha
Copy link
Member

Signed-off-by: Howard Pritchard howardp@lanl.gov

@hppritcha
Copy link
Member Author

related to #9203

@ibm-ompi
Copy link

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/8ffc86029ce51b0fe15c16b6e191be82

@hppritcha
Copy link
Member Author

bot:ibm:retest

@hppritcha
Copy link
Member Author

not sure I understand why the make distcheck failed. can't seem to reproduce. try again.
bot:ompi:retest

@ibm-ompi
Copy link

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/bb519b0ea46e507caca003fe9e9cee58

@hppritcha hppritcha force-pushed the topic/comm_idup_with_info branch from 697d57b to db666c4 Compare November 26, 2021 20:08
@ibm-ompi
Copy link

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/d01400360c7887013145ef2560f415aa

@hppritcha
Copy link
Member Author

hmmm... ibm output is very confusing flooded with warnings. looks like the failure got cut off of the posting. @jjhursey could you take a look?

jjhursey
jjhursey reviewed Nov 29, 2021
View reviewed changes
@jjhursey
Copy link
Member

If the gist is too long then the first link will look cut off. To see the full log you have to click the link towards the top
image

It looks like the error is:

"mpi-f-interfaces-bind.h", line 1622.1: 1516-194 (S) A binding label must not be the same as the name of a program unit, common block, external procedure, and another binding label, ignoring differences in case.
** ompi_mpifh_bindings   === End of Compilation 1 ===

I flagged the change that should fix it in a separate comment.

jjhursey
jjhursey reviewed Nov 29, 2021
View reviewed changes
@hppritcha hppritcha force-pushed the topic/comm_idup_with_info branch 2 times, most recently from 12aed65 to 8b5220f Compare November 29, 2021 18:43
@hppritcha hppritcha changed the title implement MPI_Comm_idup_with_info MPI4:implement MPI_Comm_idup_with_info Nov 29, 2021
@hppritcha
implement MPI_Comm_idup_with_info
a79f8b5 
Signed-off-by: Howard Pritchard <howardp@lanl.gov>
@hppritcha hppritcha force-pushed the topic/comm_idup_with_info branch from 8b5220f to a79f8b5 Compare December 21, 2021 20:16
@hppritcha hppritcha requested review from jsquyres and removed request for ggouaillardet January 4, 2022 16:06
jsquyres
jsquyres requested changes Jan 19, 2022
View reviewed changes
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like MPI_Comm_idup_with_info wasn't added to the 2 mpi module implementations (tkr and ignore-tkr). Was that intentional?

@jsquyres jsquyres mentioned this pull request Jan 19, 2022
Merged
@hppritcha
remove extraneous makefile
f3aead7 
Signed-off-by: Howard Pritchard <howardp@lanl.gov>
@hppritcha
add mpi_comm_idup_with info to additional
169f3f9 
fortran modules

Signed-off-by: Howard Pritchard <howardp@lanl.gov>
@hppritcha hppritcha force-pushed the topic/comm_idup_with_info branch from 229fb50 to 169f3f9 Compare January 19, 2022 14:59
@hppritcha hppritcha requested a review from jsquyres January 19, 2022 15:47
jsquyres
jsquyres approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you squash?

@hppritcha hppritcha merged commit 22bc7d2 into open-mpi:master Jan 24, 2022
@hppritcha hppritcha mentioned this pull request Feb 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjhursey jjhursey jjhursey left review comments

@jsquyres jsquyres jsquyres approved these changes

Assignees
No one assigned
Labels
MPI-4.0 Target: main Target: v5.0.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hppritcha @ibm-ompi @jjhursey @jsquyres