libnbc: Fix int overflow when handling count parameters #9616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In a reduce_scatter operation if the count array adds up to a
value greater than INT_MAX then the count passed around is negative
leading to an invalid buffer bring passed around often resulting in
a segv crash.
* The fix is to preserve the true count size as a `size_t` at all
levels in the schedule (thus why there is a change to the protocol
structures).
- Instead of changing the count parameter of `ompi_op_reduce` we
iterate over INT_MAX chunks of the buffer reducing each in turn.
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
bosilca
reviewed
Nov 2, 2021
* If the `count` is greater than `INT_MAX` then we call the operation in chunks that fit into an `int`. * This moves the functionality out of libnbc and into the common reduction operation so that all collectives may pass larger counts than `INT_MAX` into the internal reduction operation. Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
jjhursey
force-pushed
the
libnbc-fix-overflow
branch
from
972e9c4 to
6075048
Compare
bosilca
approved these changes
Nov 3, 2021
|
Cherry picked both patches to the release branches. If the RMs for a release don't want the second change we can drop it on those branches - I would prefer to keep both patches on all release branches: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
value greater than INT_MAX then the count passed around is negative
leading to an invalid buffer bring passed around often resulting in
a segv crash.
size_tat alllevels in the schedule (thus why there is a change to the protocol
structures).
ompi_op_reduceweiterate over INT_MAX chunks of the buffer reducing each in turn.