v4.0.x: libevent: Do not force addition of linker flags #9024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OPAL_CHECK_PACKAGE expects the libdir argument to be an empty string unless the user specifically requested a specific libdir. In that case, we should always add a linker search flag for that directory, as the user is specifying a directory location. The external libevent configure code was trying to find an external libevent library and then set the libdir to OPAL_CHECK_PACKAGE as the found libdir, but without all the smarts to not add unnecessary search flags. This resulted in a -L/usr/lib appearing early in our explicit search paths if a user specified --with-libevent=/usr. Signed-off-by: Brian Barrett <bbarrett@amazon.com> (cherry picked from commit 75e82db)
jsquyres
changed the title
jsquyres
approved these changes
Jun 2, 2021
|
Refs #8990 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPAL_CHECK_PACKAGE expects the libdir argument to be an empty string
unless the user specifically requested a specific libdir. In that
case, we should always add a linker search flag for that directory,
as the user is specifying a directory location. The external
libevent configure code was trying to find an external libevent
library and then set the libdir to OPAL_CHECK_PACKAGE as the
found libdir, but without all the smarts to not add unnecessary
search flags. This resulted in a -L/usr/lib appearing early in
our explicit search paths if a user specified --with-libevent=/usr.
Signed-off-by: Brian Barrett bbarrett@amazon.com
(cherry picked from commit 75e82db)