v5.0.x: Use reference-counted immutable strings with info objects #8600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu> (cherry picked from commit aa25d10)
The key and info strings are now stored as opal_cstring_t objects so returning them works by incrementing their reference count. The caller is responsible for releasing the objects eventually. This avoids many unnecessary string copy operations, which are now only required if the string is to be modified (e.g., passed to strtok). Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu> (cherry picked from commit dc42985)
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu> (cherry picked from commit 40ac165)
Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu> (cherry picked from commit 3c5c132)
devreal
changed the title
devreal
changed the title
jsquyres
approved these changes
Mar 12, 2021
awlauria
changed the title
awlauria
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #8330 to 5.0.x, see there for details on the new info string handling.