osc/ucx: convert ATOMIC_SIZE_SUPPORTED from a macro to static inline … #8595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Normally I would leave this macro in place but this one is worthwhile to update. |
devreal
approved these changes
Mar 12, 2021
hjelmn
force-pushed
the
lets_make_this_static_inline_instead
branch
from
93b2af9 to
cafd054
Compare
…function Generally speaking static inline functions are the better choice. Open MPI generally leave the old macro usage in place but this macro is not ideal as written. (_remote_addr) & 0x3 is interpreted to be a cast by clang-format. While not right it does not have enough information in the limited scope to decide it definitely is not a cast. I will try to patch this case in llvm but for not it is better to just modernize this piece of code to avoid the issue altogether. Signed-off-by: Nathan Hjelm <hjelmn@google.com>
hjelmn
force-pushed
the
lets_make_this_static_inline_instead
branch
from
cafd054 to
61089d7
Compare
|
bot:aws:retest |
awlauria
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…function
Generally speaking static inline functions are the better choice. Open MPI
generally leave the old macro usage in place but this macro is not ideal
as written. (_remote_addr) & 0x3 is interpreted to be a cast by
clang-format. While not right it does not have enough information in the
limited scope to decide it definitely is not a cast. I will try to patch
this case in llvm but for not it is better to just modernize this piece of
code to avoid the issue altogether.
Signed-off-by: Nathan Hjelm hjelmn@google.com