Pr/v4.0.x mpich3.4 tstsuite fixes #8443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If MPI_MODE_SEQUENTIAL was used when opening the file, the special displacement MPI_DISPLACEMENT_CURRENT has to be used during file_set_view. The displacement is set to the current position of the shared file pointer in this case. It is illegal to use MPI_DISPLACEMENT_CURRENT unless amode MPI_MODE_SEQUENTIAL was used. Signed-off-by: Edgar Gabriel <egabriel@central.uh.edu> (cherry picked from commit 6168dde)
aio_return returns the number of bytes written/read, and can indicate a partial completion. This fix ensures that a partially completed aio_read/write operation is reposted correctly. Fixes the i_bigtype test from the mpich testsuite. Signed-off-by: Edgar Gabriel <egabriel@central.uh.edu> (cherry picked from commit 79561ee)
you cannot access parts of a file if the file view contains a description that leads ultimately to a negative offset. This fix ensures that we return an error in this case (MPI_ERR_IO). This fix was triggered by an investigation into mpich/test/mpi/io/tst_fileview testcase. Running this test with ompio still leads to a number of 'failures' since we return MPI_ERR_TYPE in some instances, while the testcode expects MPI_ERR_IO. I will not fix those issues, since this is like playing guacamole (fixing the error code expected by one testsuite makes another testsuite fail). However, this commit fixes the one case where we returned MPI_SUCCESS instead of an error code. Signed-off-by: Edgar Gabriel <egabriel@central.uh.edu> (cherry picked from commit 0761c0b)
raafatfeki
approved these changes
Feb 4, 2021
|
@edgargabriel were these commits triggered by a user report? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.