Skip to content

Update PRRTE #7685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2020
Merged

Update PRRTE #7685

merged 1 commit into from
May 4, 2020

Conversation

rhc54
Copy link
Contributor

@rhc54 rhc54 commented May 4, 2020

Protect against systems that forward entire environment

Signed-off-by: Ralph Castain rhc@pmix.org

Protect against systems that forward entire environment

Signed-off-by: Ralph Castain <rhc@pmix.org>
@ibm-ompi
Copy link

ibm-ompi commented May 4, 2020

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/6814c4ad4a1a314bd78cc87475c7b553

@ibm-ompi
Copy link

ibm-ompi commented May 4, 2020

The IBM CI (PGI) build failed! Please review the log, linked below.

Gist: https://gist.github.com/2c88560e523c109aa612f3de86a5cc83

@rhc54
Copy link
Contributor Author

rhc54 commented May 4, 2020

@jjhursey I'm getting flooded with warnings such as this:

"../../opal/include/opal/sys/powerpc/atomic.h", line 404: warning: "cc" clobber
          ignored
  OPAL_ATOMIC_POWERPC_DEFINE_ATOMIC_32(sub, subf)
  ^

"../../opal/include/opal/sys/powerpc/atomic.h", line 404: warning: variable "t"
          was set but never used
  OPAL_ATOMIC_POWERPC_DEFINE_ATOMIC_32(sub, subf)
  ^

"../../opal/include/opal/sys/powerpc/atomic.h", line 141: warning: "cc" clobber
          ignored
                            : "cc", "memory");
                              ^

"../../opal/include/opal/sys/powerpc/atomic.h", line 141: warning: "cc" clobber
          ignored
                            : "cc", "memory");
                              ^

It is making it near-impossible to find the actual error. Can someone track down these warnings and fix them?

@rhc54
Copy link
Contributor Author

rhc54 commented May 4, 2020

@jjhursey Ditto down in PMIx plus a flood of these (and suspect I would find the same in PRRTE):

"/tmp/ompi-src/opal/mca/pmix/pmix4x/openpmix/src/threads/thread_usage.h", line
          71: warning: the "always_inline" attribute is ignored on non-inline
          functions
  PMIX_THREAD_DEFINE_ATOMIC_COMPARE_EXCHANGE(void *, intptr_t, ptr)
  ^

"/tmp/ompi-src/opal/mca/pmix/pmix4x/openpmix/src/threads/thread_usage.h", line
          72: warning: the "always_inline" attribute is ignored on non-inline
          functions
  PMIX_THREAD_DEFINE_ATOMIC_SWAP(int32_t, int32_t, 32)
  ^

"/tmp/ompi-src/opal/mca/pmix/pmix4x/openpmix/src/threads/thread_usage.h", line
          73: warning: the "always_inline" attribute is ignored on non-inline
          functions
  PMIX_THREAD_DEFINE_ATOMIC_SWAP(void *, intptr_t, ptr)
  ^

"/tmp/ompi-src/opal/mca/pmix/pmix4x/openpmix/src/threads/thread_usage.h", line
          126: warning: the "always_inline" attribute is ignored on non-inline
          functions
  PMIX_THREAD_DEFINE_ATOMIC_OP(int64_t, add, +, 64)
  ^

@rhc54
Copy link
Contributor Author

rhc54 commented May 4, 2020

bot:ibm:retest

@rhc54 rhc54 merged commit 1b6622f into open-mpi:master May 4, 2020
@rhc54 rhc54 deleted the topic/sync branch May 4, 2020 16:13
@jjhursey
Copy link
Member

jjhursey commented May 4, 2020

It seems to be PGI compiler related. I don't see it with GCC or XL.
I filed a ticket (Issue #7686) and assigned it to IBM to cleanup so we don't forget about it.

Looking at the OpenPMIx Jenkins logs for master I don't see these warnings, but we are definitely seeing warnings about PMIx code here. Maybe we are getting an additional flag from OMPI's configure that it making PGI more verbose. We'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants