Skip to content

coll/tuned: Fix MPI_IN_PLACE processing in tuned algorithms #5970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2018
Merged

coll/tuned: Fix MPI_IN_PLACE processing in tuned algorithms #5970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions ompi/mca/coll/tuned/coll_tuned_decision_fixed.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,11 @@ int ompi_coll_tuned_alltoall_intra_dec_fixed(const void *sbuf, int scount,
the University of Tennessee (2GB MX) up to 64 nodes.
Has better performance for messages of intermediate sizes than the old one */
/* determine block size */
ompi_datatype_type_size(sdtype, &dsize);
if (MPI_IN_PLACE != sbuf) {
ompi_datatype_type_size(sdtype, &dsize);
} else {
ompi_datatype_type_size(rdtype, &dsize);
}
block_dsize = dsize * (ptrdiff_t)scount;

if ((block_dsize < (size_t) ompi_coll_tuned_alltoall_small_msg)
Expand Down Expand Up @@ -549,7 +553,11 @@ int ompi_coll_tuned_allgather_intra_dec_fixed(const void *sbuf, int scount,
}

/* Determine complete data size */
ompi_datatype_type_size(sdtype, &dsize);
if (MPI_IN_PLACE != sbuf) {
ompi_datatype_type_size(sdtype, &dsize);
} else {
ompi_datatype_type_size(rdtype, &dsize);
}
total_dsize = dsize * (ptrdiff_t)scount * (ptrdiff_t)communicator_size;

OPAL_OUTPUT((ompi_coll_tuned_stream, "ompi_coll_tuned_allgather_intra_dec_fixed"
Expand Down Expand Up @@ -644,7 +652,12 @@ int ompi_coll_tuned_allgatherv_intra_dec_fixed(const void *sbuf, int scount,
}

/* Determine complete data size */
ompi_datatype_type_size(sdtype, &dsize);
if (MPI_IN_PLACE != sbuf) {
ompi_datatype_type_size(sdtype, &dsize);
} else {
ompi_datatype_type_size(rdtype, &dsize);
}

total_dsize = 0;
for (i = 0; i < communicator_size; i++) {
total_dsize += dsize * (ptrdiff_t)rcounts[i];
Expand Down