v2.x: errhandler_predefined: remove erroneous assert() #5506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@hppritcha As cited in the description, this is not a cherry pick because the issue is specific to the v2.x branch (i.e., the issue was introduced when master commit 35438ae was backported / cherry-picked to v2.x and committed in 13ddcbf). |
jsquyres
changed the title
This assert() was added in 13ddcbf (which was a back-ported cherry pick from master: 35438ae), but it is actually exactly the opposite assertion that should be there. Additionally, the assert() is superflouous, because the "if" statement resulting in invoking this function is exactly what the assert() should be. Hence, the simplest solution here is just to remove that assert(). Note that this assert() is not present on master: it's only on the v2.x branch. Hence, this is not a cherry-pick from master -- it's a direct PR to the v2.x branch. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
jsquyres
force-pushed
the
pr/v2.x/fix-predefined-errhandler-backend-fatal-aggregate-assert
branch
from
bc79c3c to
fe4ee5c
Compare
bosilca
approved these changes
Aug 1, 2018
hppritcha
approved these changes
Aug 1, 2018
Member
|
@jsquyres please merge after CI |
jsquyres
deleted the
pr/v2.x/fix-predefined-errhandler-backend-fatal-aggregate-assert
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assert() was added in 13ddcbf (which was a back-ported cherry
pick from master: 35438ae), but it is actually exactly the
opposite assert that should be there. The assert() is actually
superflouous, because the "if" statement resulting in invoking this
function is exactly what the assert() should be. Hence, the simplest
solution here is just to remove that assert().
This assert() is not present on master: it's only on the v2.x branch.
Hence, this is not a cherry-pick from master -- it's a direct PR to
the v2.x branch.
Signed-off-by: Jeff Squyres jsquyres@cisco.com
This issue found in Cisco MTT runs -- see https://mtt.open-mpi.org/index.php?do_redir=2657