Skip to content

Conversation

@jsquyres
Copy link
Member

@jsquyres jsquyres commented Mar 29, 2018

Simple MCA vars for ext1, ext2, and pmix3 components to reflect what
the underlying PMIx library version is. For example:

$ ompi_info --param pmix pmix3x --parsable --level 9 | grep library_version
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:value:PMIx library version 3.0.0 (embedded in Open MPI)
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:source:default
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:status:writeable
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:level:4
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:help:Version of the underlying PMIx library
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:deprecated:no
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:type:string
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:disabled:false

Signed-off-by: Jeff Squyres jsquyres@cisco.com

Simple MCA vars for ext1, ext2, and pmix3 components to reflect what
the underlying PMIx library version is.  For example:

```
$ ompi_info --param pmix pmix3x --parsable --level 9 | grep
library_version
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:value:PMIx library version 3.0.0 (embedded in Open MPI)
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:source:default
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:status:writeable
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:level:4
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:help:Version of the underlying PMIx library
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:deprecated:no
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:type:string
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:disabled:false
```

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
@jsquyres
Copy link
Member Author

@rhc54 @jjhursey Questions:

  1. I don't have an easy way to test the ext1x and ext2x components -- could one of you test those?
  2. I notice that there's an ext3x component, but I didn't see any of the usual component infrastructure in there -- is that intended?
  3. I don't know what the other PMIx components are (s1, s2, isolated, ...). It would be easy to add this stuff to those components, but I feel even less confident adding it because I can't compile/test at all.

@jsquyres
Copy link
Member Author

@hjelmn In this PR, I created an MCA_BASE_VAR_SCOPE_CONSTANT MCA var, but when I query it in ompi_info, it shows up as writable -- is this intended?

$ ompi_info --param pmix pmix3x --parsable --level 9 | grep library_version
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:value:PMIx library version 3.0.0 (embedded in Open MPI)
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:source:default
mca:pmix:pmix3x:param:pmix_pmix3x_library_version:status:writeable
...

@hjelmn
Copy link
Member

hjelmn commented Mar 29, 2018

Hmm, I thought we made sure the settable flag was unset on constant scope.

@jjhursey
Copy link
Member

jjhursey commented Apr 2, 2018

bot:ibm:pgi:retest
bot:ibm:gnu:retest

Copy link
Member

@jjhursey jjhursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks!

@jsquyres
Copy link
Member Author

jsquyres commented Apr 4, 2018

@jjhursey Does this stuff need to be added to s1/s2/etc.?

@jsquyres jsquyres merged commit a2fc1ac into open-mpi:master Apr 4, 2018
@jsquyres jsquyres deleted the pr/pmix-version-info-mca-vars branch April 4, 2018 21:29
@jjhursey
Copy link
Member

jjhursey commented Apr 4, 2018

I don't know if s1 and s2 have versions we need to pull. I think just focusing on the pmix components is enough for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants