v2.x: configury: Make more robust in finding NAG Fortran Compiler #4879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggouaillardet
approved these changes
Mar 6, 2018
The NAG Fortran check only matched "nagfor" exactly, and failed if a path to nagfor was provided. Also change "-pthread" into "-Wl,-pthread". Signed-off-by: Themos Tsikas <themos.tsikas@nag.co.uk> Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit a8fc30f)
jsquyres
force-pushed
the
pr/v2.x/nag-fortran-configury-update
branch
from
d411168 to
43298b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NAG Fortran check only matched "nagfor" exactly, and failed if a
path to nagfor was provided. Also change "-pthread" into
"-Wl,-pthread".
Signed-off-by: Themos Tsikas themos.tsikas@nag.co.uk
Signed-off-by: Jeff Squyres jsquyres@cisco.com
(cherry picked from commit a8fc30f)
@hppritcha This can slot in whatever v2.1.x release we want -- it is not absolutely needed for v2.1.3. OTOH, it's a pretty trivial update (it's not obvious from the github rendering, but it's a 1-character change).
FTI @ThemosTsikas