opal_path_nfs: ensure arrays are always long enough #4179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test used to have fixed-sized arrays for the mounts that it was checking. However, we periodically run across machines with more mounts than can fit into those fixed-size arrays. Rather than periodically increasing the size of those arrays (after re-discovering that the error is due to fixed-size arrays), just count how many entries there are and make arrays that are big enough. Additionally, add a check to ensure that we don't go over the max size of the array when reading/filling them. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
bwbarrett
approved these changes
Sep 6, 2017
|
Let's go with this over #4176. |
This was referenced Sep 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #4176. Both PRs solve the problem -- this one just allows us to check all mount points (even if there are more than 512). Which may seem overkill. But what the hell -- isn't overkill the Open MPI Way?
(specifically: only #4716 or this one should be merged -- not both)
This test used to have fixed-sized arrays for the mounts that it was checking. However, we periodically run across machines with more mounts than can fit into those fixed-size arrays. Rather than periodically increasing the size of those arrays (after re-discovering that the error is due to fixed-size arrays), just count how many entries there are and make arrays that are big enough.
Additionally, add a check to ensure that we don't go over the max size of the array when reading/filling them.
Signed-off-by: Jeff Squyres jsquyres@cisco.com