Cover the use-cases for OPAL_PREFIX and PMIX_INSTALL_PREFIX options #4012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 3, 2017
jjhursey
approved these changes
Aug 5, 2017
jjhursey
reviewed
Aug 5, 2017
orte/orted/orted_submit.c
Outdated
| opal_unsetenv(OPAL_MCA_PREFIX"pmix", &orte_launch_environ); | ||
| /* clear any install_prefix that might have been set so | ||
| * we don't cause our children to falsely generate warnings */ | ||
| opal_unsetenv("PMIX_INSTALL_PREFIX", &orte_launch_environ); |
There was a problem hiding this comment.
Question:
Do we want to clear PMIX_INSTALL_PREFIX here? What if it was set in the user's environment to point to the correct external PMIx install (assume they are also configured Open MPI with an external PMIx). Wouldn't the children need this value to be set when they are launched as well?
There was a problem hiding this comment.
That's fine - it was being cleared to avoid conflicts on the internal version if OPAL_PREFIX was set and we then set PMIX_INSTALL_PREFIX in the daemon, thus delivering both to the child.
…hes between location directives for OPAL and PMIx. Provide a more helpful error message and error out if we find a mismatch. If any OPAL values are set and the PMIx equivalent is not, then transfer it. Do not clear PMIX_INSTALL_PREFIX from the daemon's launch environment Fixes #3980 Closes #4007 Refs #3985 Signed-off-by: Ralph Castain <rhc@open-mpi.org>
|
@artpol84 This look okay to you too? |
artpol84
reviewed
Aug 7, 2017
| } | ||
| OPAL_LIST_DESTRUCT(&values); | ||
| return OPAL_SUCCESS; | ||
| } |
There was a problem hiding this comment.
ohh, it's a return - never mind then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3980
Closes #4007
Refs #3985
Signed-off-by: Ralph Castain rhc@open-mpi.org