v2.0.x: fortran: Fix MPI_ARGV(S)_NULL compilation error
#3535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fortran constants `MPI_ARGV_NULL` and `MPI_ARGVS_NULL` are defined in MPI-3.1 p.680 as below. > `MPI_ARGVS_NULL` > 2-dim. array of `CHARACTER*(*)` > `MPI_ARGV_NULL` > array of `CHARACTER*(*)` `MPI_ARGV_NULL` and `MPI_ARGVS_NULL` are used as an argument of `MPI_COMM_SPAWN` and `MPI_COMM_SPAWN_MULTIPLE` respectively and their argument `argv` and `array_of_argv` are defined as below for `USE mpi_f08` binding in MPI-3.1. ``` CHARACTER(LEN=*), INTENT(IN) :: argv(*) CHARACTER(LEN=*), INTENT(IN) :: array_of_argv(count, *) ``` Defining them as `INTEGER` in `mpi_f08` module will cause a compilation error of user programs like "There is no specific subroutine for the generic 'mpi_comm_spawn'". Signed-off-by: KAWASHIMA Takahiro <t-kawashima@jp.fujitsu.com> (cherry picked from commit open-mpi/ompi@0fcd964)
ggouaillardet
approved these changes
May 16, 2017
Contributor
ggouaillardet
left a comment
ggouaillardet
left a comment
There was a problem hiding this comment.
i am fine with this.
strictly speaking, that might be an ABI change, but since we fix something that never worked before, i guess this is acceptable before v3.x
@jsquyres any thoughts ?
Member
|
I think given the nature of the bug that this PR fixes, it's okay even if it's technically an ABI change. |
Member
|
I agree: it couldn't have worked before, so the fact that we're breaking ABI isn't too important here. |
Member
|
@hppritcha Good to go. @bwbarrett @hppritcha Merging this fix into v2.0.x/v2.x means you also need to merge #3533 into v3.0.x. It's a definite bug, and the risk/impact is low. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ggouaillardet Could you review?
Corresponding master PR: #3401
(cherry picked from commit 0fcd964)