v2.x: pmix/pmix112: Correct --enable-pmix-dstore option
#2859
Conversation
|
bot:lanl:retest |
| @@ -43,7 +43,7 @@ AC_DEFUN([MCA_opal_pmix_pmix112_CONFIG],[ | |||
| [AC_HELP_STRING([--enable-pmix-dstore], | |||
| [Enable PMIx shared memory data store (default: disabled)])]) | |||
| AC_MSG_CHECKING([if PMIx shared memory data store is enabled]) | |||
| if test "$enable_pmix3_dstore" == "yes"; then | |||
| if test "$enable_pmix_dstore" = "yes"; then | |||
There was a problem hiding this comment.
Let's change this selection statement to match master to make it easier to compare the branches:
if test "$enable_pmix_dstore" != "no"; then
kawashima-fj
force-pushed
the
pr/v2.x/config-pmix-dstore
branch
from
9fa9e6d to
3e903aa
Compare
|
@jjhursey Updated. Please review again. I confirmed options passed to PMIx with this change.
|
|
Failure of LANL-disable-dlopen is caused by enabling dstore because I can reproduce the problem on my local environment. An MPI program spawned by mpiexec runs successfully but singleton fails. The singleton ESS in MPI program forks orted with the In source code, the https://github.com/open-mpi/ompi/blob/v2.x/orte/mca/ess/singleton/ess_singleton_module.c#L615 |
|
Ok, will take a look - thx! |
|
We can address the LANL-disable-dlopen runtime issue in a separate PR since this PR is only uncovering an existing issue. |
The Open MPI `configure` option to enable PMIx shared meory dstore is now `--enable-pmix-dstore`, not `--enable-pmix3-dstore`. Without this fix, The `--disable-dstore` is always passed to PMIx `configure` regardless of the Open MPI `configure` option. And, == is bash extention. The default is still `--disable-pmix-dstore`. Signed-off-by: KAWASHIMA Takahiro <t-kawashima@jp.fujitsu.com>
kawashima-fj
force-pushed
the
pr/v2.x/config-pmix-dstore
branch
from
3e903aa to
757d85b
Compare
|
@jjhursey @rhc54 @jsquyres @hppritcha Pulling this PR without fixing the singleton + dstore problem will cause LANL-disable-dlopen failure on all PRs for v2.x branch. Let's split the changes if we cannot resolve the problem soon.
I reverted the default in the commit a few minutes ago to address only 1. Without 1, we cannot enable dstore of embedded PIMx through the Open MPI configure option. I confirmed that the problem exists only in v2.x branch. |
|
@kawashima-fj This looks good, and preserves the default disabled behavior for this feature. I agree with your plan noted in this comment. Now that PR #2909 is in, I think all that is left is a PR making dstore default enabled. Is that correct? |
@jjhursey This is the intended option, right?
The Open MPI
configureoption to enable PMIx shared meory dstoreis now
--enable-pmix-dstore, not--enable-pmix3-dstore.Without this fix, The
--disable-dstoreis always passed to PMIxconfigureregardless of the Open MPIconfigureoption.And,
==is bash extention.This bug exists only in v2.x branch. No master and v2.0.x.
Signed-off-by: KAWASHIMA Takahiro t-kawashima@jp.fujitsu.com