sync_builtin: check for 64-bit atomic support #1659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ggouaillardet @PHHargrove I went ahead and added a check for 64-bit __sync atomics. It shouldn't be necessary (a macro exists that indicated whether a platform supports 64-bit asm) but this is safer than relying on that macro. |
This commit adds an additional check for 64-bit atomic support for __sync builtins. If 64-bit support is not available the opal_atomic_*_64 atomics are disabled. Signed-off-by: Nathan Hjelm <hjelmn@me.com>
|
Works for me now. 👍 |
This commit changes the asm configure logic to fall back on inline asm atomics on systems that 1) have __sync atomics, 2) do not have 64-bit __sync atomics, and 3) support 64-bit asm. Signed-off-by: Nathan Hjelm <hjelmn@me.com>
|
@PHHargrove addressed your other concern. The second commit will fall back on inline asm on x86 if the compiler does not implement 64-bit __sync atomics. |
|
@hjelmn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an additional check for 64-bit atomic support for _sync
builtins. If 64-bit support is not available the opal_atomic*_64 atomics
are disabled.
Signed-off-by: Nathan Hjelm hjelmn@me.com