fix some memleak #13305
Closed
fix some memleak #13305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avx_component module retain twice by avx_component_op_query and ompi_op_base_op_select function opal_common_ucx ucx tls and devices not free opal_patcher_base_framework not close Signed-off-by: wjjahah <2457791952@qq.com>
bosilca
reviewed
Jun 12, 2025
There was a problem hiding this comment.
I am skeptical about the op and patcher change, I need to look into the code a little more to understand the scope.
I mostly certain the ucx change is incorrect. People put a lengthy comment on why they did that (comment this patch removes), and the proposed patch removes exactly that protection.
Signed-off-by: wjjahah <2457791952@qq.com>
|
thanks for review, ucx commit is not correct, see #11640 get the reason, I will close this pr and create a new |
|
You dont have to close the PR in order to change it, even drastically. The PR is based on the diff between your branch and the main. In general sticking with the same PR is preferable, as it will keep all the discussions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avx_component module retain twice by avx_component_op_query and ompi_op_base_op_select function opal_common_ucx ucx tls and devices not free
opal_patcher_base_framework not close