comm: beef up args checking for some comm constructors #12975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
approved these changes
Dec 10, 2024
The MPI_Comm_create_from_group and especially the MPI_Intercomm_create_from_groups functions are recent additions to the standard (MPI 4.0) and users may get confused easily trying to use them. So better parameter checking is needed. Related to open-mpi#12906 where an incorrect code example showed up. Signed-off-by: Howard Pritchard <howardp@lanl.gov> (cherry picked from commit a0486e0)
hppritcha
force-pushed
the
better_arg_checks_for_comm_create_from_group_v50x
branch
from
7493487 to
3796286
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MPI_Comm_create_from_group and especially the
MPI_Intercomm_create_from_groups functions are recent additions to the standard (MPI 4.0) and users may get confused easily trying to use them.
So better parameter checking is needed.
Related to #12906 where an incorrect code example showed up.
Signed-off-by: Howard Pritchard howardp@lanl.gov
(cherry picked from commit a0486e0)