Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use opal_argv_join_range() for opal_var_dump_color_keys #11829

Closed
wants to merge 1 commit into from
Closed

Don't use opal_argv_join_range() for opal_var_dump_color_keys #11829

wants to merge 1 commit into from

Commits on Jul 19, 2023

  1. Don't use opal_argv_join_range() for opal_var_dump_color_keys 

    The join function was initially used for convinience, to print the
valid keys. This was wrong, because opal_var_dump_color_keys is not
a NULL-terminated array. This commit replaces it with an asprintf loop.

Thanks to Niv Shpak (@nivShpak) for reporting this and identifying the root cause.

Signed-off-by: George Katevenis <gkatev@ics.forth.gr>
    @gkatev
    gkatev committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    1455fae View commit details
    Browse the repository at this point in the history