opal/ofi: follow up fixes to package rank calculation #11710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make error log less verbose Signed-off-by: Wenduo Wang <wenduwan@amazon.com>
The previous change caused inconsistent package rank when the process is unbound - two processes could return the same package rank. If the process is unbound, OPAL_MODEX_RECV_VALUE_OPTIONAL throws an error, in which case and we should fallback to the process id instead of attempting to return a local package rank. Signed-off-by: Wenduo Wang <wenduwan@amazon.com>
wenduwan
force-pushed
the
fix_package_rank
branch
from
55b489f to
1a1b84a
Compare
lrbison
approved these changes
May 24, 2023
|
Code change looks good. What's the best test for this @wenduwan ? |
@lrbison We want to test mpi init with I've tested this with osu_bw - just need to check the mpi init log. The patch gets rid of the help-common-ofi message, which is our goal. There is another fix for a bug introduced by Amir's earlier change #11711 which will further reduce the warnings. |
|
Thank you! Looks good to me. |
hppritcha
approved these changes
May 24, 2023
|
@lrbison Shall we merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed new issues caused by the previous change #11693 when the process is unbound: