OFI/MTL: bypass HMEM mem reg for CXI provider #11076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in the OFI MTL to register acclerator memory doesn't work well with providers like CXI which require the libfabric consumer to specify the requested_key field in the fi_mr_attr arg to fi_mr_regattr. As it turns out there's a simpe workaround though with this provider as it actually doesn't need accelerator memory to be registered for FI_MSG/FI_TAGGED type transfers. This patch restores support for transfers to/from accelerator memory using the OFI MTL on SS11 (CXI provider). Signed-off-by: Howard Pritchard <howardp@lanl.gov>
wckzhang
approved these changes
Nov 15, 2022
|
I will consider the addr check for a subsequent PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in the OFI MTL to register acclerator memory doesn't work well with providers like CXI which require the libfabric consumer to specify the requested_key field in the fi_mr_attr arg to fi_mr_regattr. As it turns out there's a simpe workaround though with this provider as it actually doesn't need accelerator memory to be registered for FI_MSG/FI_TAGGED type transfers.
This patch restores support for transfers to/from accelerator memory using the OFI MTL on SS11 (CXI provider).
Signed-off-by: Howard Pritchard howardp@lanl.gov