Skip to content

Gcc atomic fixes v5.0.x #10722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Gcc atomic fixes v5.0.x #10722

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27d88bb
GCC atomics: acquire thread-fence was busted until GCC 8.1.0
devreal Jul 26, 2022
e529e6b
GCC atomics: fix lock initialization if HLE is enabled
devreal Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions opal/include/opal/sys/gcc_builtin/atomic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
*
*********************************************************************/

#if defined(PLATFORM_ARCH_X86_64) && defined (__GNUC__) && !defined(__llvm) && (__GNUC__ < 6)
#if defined(PLATFORM_ARCH_X86_64) && defined(PLATFORM_COMPILER_GNU) && __GNUC__ < 8
/* work around a bug in older gcc versions where ACQUIRE seems to get
* treated as a no-op instead */
#define OPAL_BUSTED_ATOMIC_MB 1
Expand Down Expand Up @@ -193,7 +193,7 @@ static inline intptr_t opal_atomic_swap_ptr(opal_atomic_intptr_t *addr, intptr_t

static inline void opal_atomic_lock_init(opal_atomic_lock_t *lock, int32_t value)
{
lock = value;
*lock = value;
}

static inline int opal_atomic_trylock(opal_atomic_lock_t *lock)
Expand Down