Move MPI Standard version to VERSION file #10683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjhursey
force-pushed
the
mpi_version_config
branch
from
4ca0766 to
2c0a74a
Compare
jjhursey
force-pushed
the
mpi_version_config
branch
from
2c0a74a to
a1dcb62
Compare
bwbarrett
approved these changes
Aug 17, 2022
| # | ||
| # MPI_VERSION | ||
| # MPI_SUBVERSION | ||
| m4_define([OPAL_GET_MPI_STANDARD_VERSION],[ |
Member
There was a problem hiding this comment.
sigh; we've broken this already, but there's no reason to use shell code at configure time. There's already a build dependency of configure on VERSION, so we can just do this all during Autoconf time (similar to how we get the version to pass to AC_INIT). No need to run a giant sed across an ever-growing version file every time someone runs configure...
Member
Author
There was a problem hiding this comment.
Yeah. I didn't want to tackle that in this change. Just trying to match what was already there.
jjhursey
force-pushed
the
mpi_version_config
branch
from
a1dcb62 to
0f5e1a3
Compare
* This puts the MPI standard major and minor version in the scope of the Makefiles so we can leverage this information when deciding build time options for non-C portions of the code (portions that do not look at `mpi.h`) - such as Fortran and Perl. Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
jjhursey
force-pushed
the
mpi_version_config
branch
from
0f5e1a3 to
bee50be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of the Makefiles so we can leverage this information when deciding
build time options for non-C portions of the code (portions that
do not look at
mpi.h) - such as Fortran and Perl.