Skip to content

Fixup: osc/ucx: implement rput and rget using ucp_worker_flush_nb #10642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Fixup: osc/ucx: implement rput and rget using ucp_worker_flush_nb #10642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c8b927
Revert "osc/ucx: implement rput and rget using ucp_worker_flush_nb"
devreal Aug 9, 2022
e7d8cc7
osc/ucx: implement rput and rget using ucp_worker_flush_nb
devreal Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ompi/mca/osc/ucx/osc_ucx_comm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,9 +1075,6 @@ int ompi_osc_ucx_rput(const void *origin_addr, int origin_count,
ret = opal_common_ucx_wpmem_flush_ep_nb(mem, target, req_completion, ucx_req);

if (ret != OMPI_SUCCESS) {
OMPI_OSC_UCX_REQUEST_RETURN(ucx_req);
return ret;

/* fallback to using an atomic op to acquire a request handle */
ret = opal_common_ucx_wpmem_fence(mem);
if (ret != OMPI_SUCCESS) {
Expand Down Expand Up @@ -1131,9 +1128,6 @@ int ompi_osc_ucx_rget(void *origin_addr, int origin_count,
ret = opal_common_ucx_wpmem_flush_ep_nb(mem, target, req_completion, ucx_req);

if (ret != OMPI_SUCCESS) {
OMPI_OSC_UCX_REQUEST_RETURN(ucx_req);
return ret;

/* fallback to using an atomic op to acquire a request handle */
ret = opal_common_ucx_wpmem_fence(mem);
if (ret != OMPI_SUCCESS) {
Expand Down