Improve error handling in openib component init and add_procs

[ompiteam]

The current error handling in module_init and add_procs is abysmal and usually results in segv's after the openib BTL returns.

Part of the issue is: what should the BTL do if add_procs() fails? I started a discussion here:

http://www.open-mpi.org/community/lists/devel/2008/08/4498.php

I have much of the cleanup work done, but need a ruling on what the BTL is supposed to do if add_procs() fails.

[ompiteam]

Imported from trac issue 1434. Created by jsquyres on 2008-08-01T22:50:12, last modified: 2012-03-28T11:09:54

[ompiteam]

Trac comment by jsquyres on 2008-08-05 07:57:53:

Per https://svn.open-mpi.org/trac/ompi/ticket/1436, we just need to make the openib component progress safe to call if add_procs() fails.

[ompiteam]

Trac comment by jsquyres on 2009-02-17 11:09:36:

1.3.2 at the earliest.

[ompiteam]

Trac comment by jsquyres on 2009-10-27 19:25:23:

This may also be related to https://svn.open-mpi.org/trac/ompi/ticket/1282. If so, it can go into v1.5. If not, we should push it off to v1.5.1.

[ompiteam]

Trac comment by jsquyres on 2009-10-27 19:27:25:

Gah -- I added the above comment on the wrong ticket. Please ignore -- leave it slated for v1.5.1.

[rhc54]

Per Mellanox, this can be closed. Any further work will be done on a separate new ticket.