Add script to test for tabs in commit range #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to prevent violations of the coding style in ompi it was decided to check any future PRs for white space violations. This script checks whether a certain commit range has introduced a tab character. See open-mpi/ompi#6831 for details. Signed-off-by: guserav <erik.zeiske@hpe.com>
jsquyres
reviewed
Aug 20, 2019
As requested in open-mpi#22 the hwloc component should not be excluded. Only a part of it should be excluded from the whitespace check. Signed-off-by: guserav <erik.zeiske@hpe.com>
bwbarrett
approved these changes
Jan 7, 2020
bwbarrett
pushed a commit
to bwbarrett/ompi-scripts
that referenced
this pull request
Jan 8, 2020
As requested in open-mpi#22 the hwloc component should not be excluded. Only a part of it should be excluded from the whitespace check. Signed-off-by: guserav <erik.zeiske@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent violations of the coding style in ompi it was
decided to check any future PRs for white space violations. This script
checks whether a certain commit range has introduced a tab character.
See open-mpi/ompi#6831 for details.
Signed-off-by: guserav erik.zeiske@hpe.com