Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

v1.10: fortran: Fix ompi_alloc_mem_cptr_f linkage error #1091

Merged
merged 1 commit into from
Apr 23, 2016
Merged

v1.10: fortran: Fix ompi_alloc_mem_cptr_f linkage error #1091

merged 1 commit into from
Apr 23, 2016

Conversation

kawashima-fj
Copy link
Member

This fixes a linkage error when configured with --disable-weak-symbols, described in open-mpi/ompi#1538 (comment)

The ompi_alloc_mem_cptr_f function for mpif-h was introduced in 052b13d but I forgot to update defines.h file.

This bug exists only in v1.10 branch because the implementation of the profiling interface support was changed in master/v2.x.

This fix should be pulled before v1.10.3 release because it's a regression since v1.10.2.

@jsquyres please review

bot:label:bug
bot:milestone:v1.10.3

This fixes a linkage error when configured with `--disable-weak-symbols`,
described in open-mpi/ompi#1538 (comment)

The `ompi_alloc_mem_cptr_f` function for `mpif-h` was introduced in 052b13d
but I forgot to update `defines.h` file.
@ompiteam-bot ompiteam-bot added this to the v1.10.3 milestone Apr 22, 2016
@kawashima-fj kawashima-fj changed the title fortran: Fix ompi_alloc_mem_cptr_f linkage error v1.10: fortran: Fix ompi_alloc_mem_cptr_f linkage error Apr 22, 2016
@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1541/ for details.

@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1542/ for details.

@jsquyres
Copy link
Member

👍

@rhc54 rhc54 merged commit 2a0672f into open-mpi:v1.10 Apr 23, 2016
ggouaillardet pushed a commit to ggouaillardet/ompi-release that referenced this pull request Jul 8, 2016
ggouaillardet pushed a commit to ggouaillardet/ompi-release that referenced this pull request Jul 11, 2016
@kawashima-fj kawashima-fj deleted the pr/v1.10/fortran-no-weak-symbol-fix branch August 12, 2016 00:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants