[Bug fix] Fix get_file_list() not returning images with uppercase extension. #725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When running
demo/demo_large_image.py
on a folder of images, no images were used for inference because theget_file_list()
function inmmyolo/utils/misc
does NOT read uppercase extension images when passing a folder as argument.Example:
Image_001.JPG
,Image_002.PNG
andImage_003.TIFF
are NOT returned by the function, but they should. Many cameras output images with uppercase extensions (such as DJI drones, for example). We should not have to rename our images to be able to infer on them.Modification
Simple fix: Inside
get_file_list()
, I simply added the existing flag:case_sensitive=False
to thescandir()
function frommmengine
.Impact
This PR simply allows users to use the
get_file_list()
function on folders that contain uppercase, lowercase, or mixed case image extensions.