-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LetterResize bug with imrescale api #105
Conversation
* [Feature] Make docker image smaller * Improve doc * Improve doc * Improve doc * Improve doc
* Use 'Compose' directly Use 'Compose' directly * avoids some unnecessary calculations avoids some unnecessary calculations. * remove whitespace remove whitespace
Hi @Nioolek I saw that you are using train to eval it . But when we using coco dataset to train, the |
I used the method you mentioned, and updated the doc. |
* [Feature] Make docker image smaller (#67) * [Feature] Make docker image smaller * Improve doc * Use Compose directly in BaseMixImageTransform (#71) * Use 'Compose' directly Use 'Compose' directly * avoids some unnecessary calculations avoids some unnecessary calculations. * remove whitespace remove whitespace * fix resize bug * fix resize bug * fix resize bug * fix * fix resize bug * add test letterresize without batchshape * fix resize bug Co-authored-by: HinGwenWoong <peterhuang0323@qq.com> Co-authored-by: jason_w <wongzheng@126.com>
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
·mmcv.imrescale· is used for keeping ratio resize. It may result in unequal input and output shape.
I changed
mmcv.imrescale
tommcv.imresize
. And optimize the code intransform.py
.Modification
Fix:
transform.py
dataset:
COCO
Now, the
![f8e3c0384d3851fc8ddd025b35be158](https://user-images.githubusercontent.com/40284075/192986937-33029da2-0175-427f-88fc-90beee8e8733.jpg)
LetterResize
is used intest
. So, we need to verify the test mAP results before and after the modification.Use pretrained model yolov5s to test:
mAP results in
README.md
:After: