Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the support of python 3.6 #657

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

fangyixiao18
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 81.84% // Head: 80.49% // Decreases project coverage by -1.35% ⚠️

Coverage data is based on head (916eff5) compared to base (a1f1dad).
Patch coverage: 74.04% of modified lines in pull request are covered.

❗ Current head 916eff5 differs from pull request most recent head 9731b93. Consider uploading reports for the commit 9731b93 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x     #657      +/-   ##
===========================================
- Coverage    81.84%   80.49%   -1.36%     
===========================================
  Files          120      141      +21     
  Lines         4176     5056     +880     
  Branches       586      671      +85     
===========================================
+ Hits          3418     4070     +652     
- Misses         645      851     +206     
- Partials       113      135      +22     
Flag Coverage Δ
unittests 80.49% <74.04%> (-1.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmselfsup/datasets/transforms/__init__.py 100.00% <ø> (ø)
mmselfsup/datasets/transforms/wrappers.py 100.00% <ø> (ø)
mmselfsup/engine/hooks/deepcluster_hook.py 38.88% <0.00%> (-0.55%) ⬇️
mmselfsup/engine/optimizers/lars.py 16.12% <ø> (ø)
mmselfsup/models/algorithms/odc.py 31.70% <ø> (ø)
mmselfsup/models/backbones/mae_vit.py 100.00% <ø> (ø)
mmselfsup/models/backbones/simmim_swin.py 86.95% <ø> (ø)
mmselfsup/models/heads/latent_heads.py 100.00% <ø> (ø)
mmselfsup/models/losses/swav_loss.py 83.01% <ø> (ø)
mmselfsup/models/necks/densecl_neck.py 85.71% <ø> (ø)
... and 83 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fangyixiao18 fangyixiao18 merged commit 7a16b4e into open-mmlab:dev-1.x Jan 10, 2023
@fangyixiao18 fangyixiao18 deleted the deprecate-py36 branch January 10, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants