[Types] Fix misleading List[Tensor] types
#2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the return type of predict() which returns postprocess_result()
MeowZheng
approved these changes
Jan 31, 2023
MengzhangLI
approved these changes
Jan 31, 2023
Codecov ReportBase: 83.40% // Head: 83.40% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## 1.x #2535 +/- ##
=======================================
Coverage 83.40% 83.40%
=======================================
Files 145 145
Lines 8510 8510
Branches 1274 1274
=======================================
Hits 7098 7098
Misses 1198 1198
Partials 214 214
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Looks like I accidentally created this PR for |
MeowZheng
added a commit
that referenced
this pull request
Feb 1, 2023
## Motivation This is essentially #2535 that I had intended to submit to the `dev-1.x` branch but accidentally submitted it directly to the `1.x` branch (apologies!). This also got approved possibly because the core devs also didn't realize this. The problem is that now `1.x` and `dev-1.x` are out of sync -- the changes introduced by #2535 will never be reflected in `dev-1.x`. ## Modification I'm proposing this "backward-merge" so that `1.x` and `dev-1.x` can be in sync again. If you look at "files changed", they are exactly the changes introduced by #2535. Co-authored-by: MeowZheng <meowzheng@outlook.com>
nahidnazifi87
pushed a commit
to nahidnazifi87/mmsegmentation_playground
that referenced
this pull request
Apr 5, 2024
…2546) ## Motivation This is essentially open-mmlab#2535 that I had intended to submit to the `dev-1.x` branch but accidentally submitted it directly to the `1.x` branch (apologies!). This also got approved possibly because the core devs also didn't realize this. The problem is that now `1.x` and `dev-1.x` are out of sync -- the changes introduced by open-mmlab#2535 will never be reflected in `dev-1.x`. ## Modification I'm proposing this "backward-merge" so that `1.x` and `dev-1.x` can be in sync again. If you look at "files changed", they are exactly the changes introduced by open-mmlab#2535. Co-authored-by: MeowZheng <meowzheng@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A few functions in the following files:
decode_head.pyencoder_decoder.pycascade_encoder_decoder.pyhave a return type annotation as
List[Tensor]whereas their actual return type isTensor. This can be seen by following the trace of what each functions return internally, which eventually leads toseg_logits: Tensor.This type annotation is misleading and confusing when a user is trying to read and understand the code.
Modification
List[Tensor]toTensor.listtoSampleList.Checklist