-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix inference api and support setting palette to SegLocalVisualizer #2475
Conversation
elif isinstance(classes, str): | ||
try: | ||
classes = get_classes(classes) | ||
except ValueError: | ||
print_log( | ||
f'Unrecognized dataset: {classes}, ' | ||
f'expect classes in {dataset_aliases}', | ||
logger='current', | ||
level=logging.ERROR) | ||
exit(-1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does classes
mean dataset name here? it's a little inappropriate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here we need to provide a proper way for users to set the classes and palette of the visualizer, but input arguments classes
and palette
are a little unclear now.
if classes is None: | ||
classes = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a little redundant
Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
Codecov ReportBase: 83.41% // Head: 83.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2475 +/- ##
===========================================
- Coverage 83.41% 83.40% -0.01%
===========================================
Files 145 145
Lines 8451 8510 +59
Branches 1259 1274 +15
===========================================
+ Hits 7049 7098 +49
- Misses 1194 1197 +3
- Partials 208 215 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…izer (open-mmlab#2475) as title Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist