Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add torch1.13 checking in CI #2402

Merged
merged 5 commits into from
Dec 13, 2022
Merged

[CI] Add torch1.13 checking in CI #2402

merged 5 commits into from
Dec 13, 2022

Conversation

xiexinch
Copy link
Collaborator

Motivation

Ref: open-mmlab/mmcv#2441

Add torch1.13 checking in CI.

@xiexinch xiexinch changed the title Add torch1.13 in CI [CI] Add torch1.13 checking in CI Dec 12, 2022
@xiexinch xiexinch added the 1.x Related issue of 1.x version label Dec 12, 2022
@ice-tong
Copy link
Contributor

Suggesting fix CI by install wheel:

     - name: Upgrade pip
        run: |
          pip install pip --upgrade
          # Install wheel for source distribution build.
          pip install wheel

Refer: https://github.com/pypa/pip/blob/22.3.1/src/pip/_internal/wheel_builder.py#L94-L97

image

@ice-tong ice-tong mentioned this pull request Dec 12, 2022
Closed
@codecov
Copy link

codecov bot commented Dec 13, 2022 •
edited
Loading

Codecov Report

Base: 83.19% // Head: 83.33% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (6cb64e3) compared to base (ea217ff).
Patch coverage: 92.69% of modified lines in pull request are covered.

❗ Current head 6cb64e3 differs from pull request most recent head 815b24e. Consider uploading reports for the commit 815b24e to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           dev-1.x    #2402      +/-   ##
===========================================
+ Coverage    83.19%   83.33%   +0.14%     
===========================================
  Files          141      143       +2     
  Lines         7998     8127     +129     
  Branches      1198     1211      +13     
===========================================
+ Hits          6654     6773     +119     
- Misses        1158     1165       +7     
- Partials       186      189       +3
Flag Coverage Δ
unittests 83.33% <92.69%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/__init__.py 100.00% <ø> (ø)
mmseg/datasets/transforms/__init__.py 100.00% <ø> (ø)
mmseg/models/decode_heads/decode_head.py 93.85% <ø> (ø)
mmseg/datasets/transforms/transforms.py 96.42% <88.88%> (ø)
mmseg/models/decode_heads/mask2former_head.py 89.65% <89.65%> (ø)
mmseg/models/decode_heads/maskformer_head.py 93.75% <93.75%> (ø)
mmseg/__init__.py 92.10% <100.00%> (ø)
mmseg/datasets/ade.py 100.00% <100.00%> (ø)
mmseg/datasets/chase_db1.py 75.00% <100.00%> (ø)
mmseg/datasets/coco_stuff.py 85.71% <100.00%> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xiexinch
Copy link
Collaborator Author

Suggesting fix CI by install wheel:

     - name: Upgrade pip
        run: |
          pip install pip --upgrade
          # Install wheel for source distribution build.
          pip install wheel

Refer: https://github.com/pypa/pip/blob/22.3.1/src/pip/_internal/wheel_builder.py#L94-L97

image

Thanks!!!

MeowZheng
MeowZheng reviewed Dec 13, 2022
View reviewed changes
.github/workflows/merge_stage_test.yml
run: pip install pip --upgrade
run: |
pip install pip --upgrade
pip install wheel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add this reference
https://github.com/pypa/pip/blob/1463081f10de6bfad81afe0d68272e7c3bedbadf/src/pip/_internal/wheel_builder.py#L94-L97

@MeowZheng MeowZheng merged commit d7b85aa into open-mmlab:dev-1.x Dec 13, 2022
MeowZheng pushed a commit to MeowZheng/mmsegmentation that referenced this pull request Dec 30, 2022
@xiexinch @MeowZheng
[CI] Add torch1.13 checking in CI (open-mmlab#2402)
a6dd035 
* Add torch1.13 in CI

* use mim install mm packages

* install all requirements

* install wheel

* add ref
MeowZheng pushed a commit to MeowZheng/mmsegmentation that referenced this pull request Dec 30, 2022
@xiexinch @MeowZheng
[CI] Add torch1.13 checking in CI (open-mmlab#2402)
9ee8f15 
Add torch1.13 in CI

use mim install mm packages

install all requirements

install wheel

add ref
MeowZheng pushed a commit that referenced this pull request Dec 30, 2022
@xiexinch @MeowZheng
[CI] Add torch1.13 checking in CI (#2402)
bfbc639 
* Add torch1.13 in CI

* use mim install mm packages

* install all requirements

* install wheel

* add ref
MeowZheng pushed a commit that referenced this pull request Dec 30, 2022
@xiexinch @MeowZheng
[CI] Add torch1.13 checking in CI (#2402)
f4dad5f 
* Add torch1.13 in CI

* use mim install mm packages

* install all requirements

* install wheel

* add ref
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
@xiexinch @MeowZheng
[CI] Add torch1.13 checking in CI (open-mmlab#2402)
f745a43 
* Add torch1.13 in CI

* use mim install mm packages

* install all requirements

* install wheel

* add ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeowZheng MeowZheng MeowZheng approved these changes

Assignees

@MengzhangLI MengzhangLI

Labels
1.x Related issue of 1.x version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiexinch @ice-tong @MeowZheng @MengzhangLI