Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support MaskFormer(NeurIPS'2021) in MMSeg 1.x #2215

Merged
merged 23 commits into from
Dec 1, 2022
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
wait for mmdet 3.0.0rc4
  • Loading branch information
MengzhangLI committed Dec 1, 2022
commit da17d28d86ee7ca07622bbd6e310dadfe5eec106
22 changes: 1 addition & 21 deletions configs/maskformer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,29 +38,9 @@ Modern approaches typically formulate semantic segmentation as a per-pixel class
- MaskFormer model needs to install [MMDetection](https://github.com/open-mmlab/mmdetection) first.

```shell
pip install "mmdet>=3.0.0rc3"
pip install "mmdet>=3.0.0rc4"
```

If related MMDetection version unfounded, you can modify [related code](https://github.com/open-mmlab/mmdetection/blob/dev-3.x/mmdet/models/dense_heads/maskformer_head.py#L106) like [MMDetection PR](https://github.com/open-mmlab/mmdetection/pull/9176) on your own to fix its bug:

From

```python
if pixel_decoder_type == 'PixelDecoder' and (
self.decoder_embed_dims != in_channels[-1]
or enforce_decoder_input_project):
```

to

```python
if type(self.pixel_decoder) == PixelDecoder and (
self.decoder_embed_dims != in_channels[-1]
or enforce_decoder_input_project):
```

Which would treat `mmdet.PixelDecoder` the same with `PixelDecoder` in this MMDetection `if` conditional statement.

## Results and models

### ADE20K
Expand Down